os.chown() operations will fail for non-root users #10

New Issue

2025-11-15T03:44:13Z

snegov commented

2025-11-15 03:44:13 +00:00

os.chown() operations will fail for non-root users

Priority: High
Component: fs.py
Type: Bug

Description

Multiple locations in the code call os.chown() without error handling. On Unix systems, only root can change file ownership, so these operations will fail for normal users.

Locations

curateipsum/fs.py:225-227
curateipsum/fs.py:377
curateipsum/fs.py:460

Problem

Normal users running backups will encounter PermissionError when trying to preserve ownership of files, causing backup to fail.

Proposed Solution

Either:

Wrap in try/except and log warning
Check if running as root before attempting
Add a flag to skip ownership preservation

try:
    os.chown(dst_path, src_stat.st_uid, src_stat.st_gid)
except PermissionError:
    _lg.debug("Cannot change ownership (not root): %s", dst_path)

Impact

High - Makes tool unusable for non-root users in current form.

# os.chown() operations will fail for non-root users **Priority:** High **Component:** fs.py **Type:** Bug ## Description Multiple locations in the code call `os.chown()` without error handling. On Unix systems, only root can change file ownership, so these operations will fail for normal users. ## Locations - `curateipsum/fs.py:225-227` - `curateipsum/fs.py:377` - `curateipsum/fs.py:460` ## Problem Normal users running backups will encounter `PermissionError` when trying to preserve ownership of files, causing backup to fail. ## Proposed Solution Either: 1. Wrap in try/except and log warning 2. Check if running as root before attempting 3. Add a flag to skip ownership preservation ```python try: os.chown(dst_path, src_stat.st_uid, src_stat.st_gid) except PermissionError: _lg.debug("Cannot change ownership (not root): %s", dst_path) ``` ## Impact **High** - Makes tool unusable for non-root users in current form.

snegov referenced this issue from a commit

2026-02-04 06:07:44 +00:00

Fix high-priority bugs and add comprehensive test coverage

snegov referenced this issue from a commit

2026-02-04 06:09:56 +00:00

Fix high-priority bugs and add comprehensive test coverage

snegov closed this issue

2026-02-04 06:09:57 +00:00

snegov referenced this issue from a commit

2026-10-11 18:58:12 +00:00

Prevent stale, truncated, or changing-file copies (#10)

Sign in to join this conversation.