Missing tests for lock file functionality #19

New Issue

2025-11-15T03:44:20Z

snegov commented

2025-11-15 03:44:20 +00:00

Missing tests for lock file functionality

Priority: High
Component: tests/test_backups.py
Type: Testing

Description

The lock file mechanism (set_backups_lock, release_backups_lock) has no unit tests, despite being critical for preventing concurrent backups.

Missing Test Coverage

Lock creation and acquisition
Lock detection when another process is running
Stale lock detection (process no longer exists)
Force flag behavior
Lock release
Corrupted lock file handling
Race conditions

Proposed Tests

def test_lock_creation(self):
    """Test lock file is created with current PID"""

def test_lock_prevents_concurrent_backup(self):
    """Test second backup is blocked when lock exists"""

def test_stale_lock_is_removed(self):
    """Test lock from dead process is cleaned up"""

def test_force_flag_overrides_lock(self):
    """Test force flag allows backup despite lock"""

def test_corrupted_lock_is_handled(self):
    """Test backup continues if lock file is corrupted"""

Impact

High - Critical functionality is untested.

# Missing tests for lock file functionality **Priority:** High **Component:** tests/test_backups.py **Type:** Testing ## Description The lock file mechanism (`set_backups_lock`, `release_backups_lock`) has no unit tests, despite being critical for preventing concurrent backups. ## Missing Test Coverage - Lock creation and acquisition - Lock detection when another process is running - Stale lock detection (process no longer exists) - Force flag behavior - Lock release - Corrupted lock file handling - Race conditions ## Proposed Tests ```python def test_lock_creation(self): """Test lock file is created with current PID""" def test_lock_prevents_concurrent_backup(self): """Test second backup is blocked when lock exists""" def test_stale_lock_is_removed(self): """Test lock from dead process is cleaned up""" def test_force_flag_overrides_lock(self): """Test force flag allows backup despite lock""" def test_corrupted_lock_is_handled(self): """Test backup continues if lock file is corrupted""" ``` ## Impact **High** - Critical functionality is untested.

snegov referenced this issue from a commit

2026-02-04 06:07:44 +00:00

Fix high-priority bugs and add comprehensive test coverage

snegov referenced this issue from a commit

2026-02-04 06:09:57 +00:00

Fix high-priority bugs and add comprehensive test coverage

snegov closed this issue

2026-02-04 06:09:58 +00:00

snegov referenced this issue from a commit

2026-10-11 18:58:14 +00:00

Document ACL, xattr, sparse-file, and hardlink backup behavior (#19)

Sign in to join this conversation.