Missing tests for core filesystem operations #20

New Issue

2025-11-15T03:44:20Z

snegov commented

2025-11-15 03:44:20 +00:00

Missing tests for core filesystem operations

Priority: High
Component: tests/test_fs.py
Type: Testing

Description

The fs.py module has no tests despite containing complex logic for copying, rsyncing, and hardlinking files.

Missing Test Coverage

copy_file() - fast file copying
copy_direntry() - copying files/dirs/symlinks
update_direntry() - updating destination entries
rsync() - the core sync logic
hardlink_dir() - recursive hardlinking
nest_hardlink() - nested hardlink creation
scantree() - recursive directory traversal
rm_direntry() - recursive deletion

Risks

Complex logic with many edge cases (symlinks, permissions, ownership)
Platform-specific behavior (macOS vs Linux)
Error handling paths are untested
Refactoring is risky without tests

Proposed Solution

Add comprehensive test coverage in tests/test_fs.py for all functions, including:

Normal cases
Edge cases (empty dirs, symlinks, etc.)
Error conditions
Permission handling
Platform-specific behavior

Impact

High - Core functionality is untested, making bugs likely and refactoring risky.

# Missing tests for core filesystem operations **Priority:** High **Component:** tests/test_fs.py **Type:** Testing ## Description The `fs.py` module has no tests despite containing complex logic for copying, rsyncing, and hardlinking files. ## Missing Test Coverage - `copy_file()` - fast file copying - `copy_direntry()` - copying files/dirs/symlinks - `update_direntry()` - updating destination entries - `rsync()` - the core sync logic - `hardlink_dir()` - recursive hardlinking - `nest_hardlink()` - nested hardlink creation - `scantree()` - recursive directory traversal - `rm_direntry()` - recursive deletion ## Risks - Complex logic with many edge cases (symlinks, permissions, ownership) - Platform-specific behavior (macOS vs Linux) - Error handling paths are untested - Refactoring is risky without tests ## Proposed Solution Add comprehensive test coverage in `tests/test_fs.py` for all functions, including: - Normal cases - Edge cases (empty dirs, symlinks, etc.) - Error conditions - Permission handling - Platform-specific behavior ## Impact **High** - Core functionality is untested, making bugs likely and refactoring risky.

snegov referenced this issue from a commit

2026-02-04 06:07:44 +00:00

Fix high-priority bugs and add comprehensive test coverage

snegov referenced this issue from a commit

2026-02-04 06:09:58 +00:00

Fix high-priority bugs and add comprehensive test coverage

snegov closed this issue

2026-02-04 06:09:59 +00:00

snegov referenced this issue from a commit

2026-10-11 18:58:14 +00:00

Document Python/external-rsync backend differences (#20)

Sign in to join this conversation.