Unaddressed TODO comments in codebase #28

New Issue

snegov · 2025-11-15T03:44:26Z

snegov commented

2025-11-15 03:44:26 +00:00

Unaddressed TODO comments in codebase

Priority: Medium
Component: Multiple
Type: Technical Debt

Description

There are several TODO comments in the code that represent unfinished features or decisions to be made.

List of TODOs

1. cli.py:99 - "add cleaning up from non-finished backups"

# TODO add cleaning up from non-finished backups
backup.cleanup_old_backups(backups_dir=backups_dir_abs,
                           dry_run=args.dry_run)

Impact: Incomplete backups could accumulate, wasting space

2. backup.py:347 - "maybe should be run if first backup too?"

# TODO maybe should be run if first backup too?
if latest_backup is not None:
    process_backed_entry(...)

Impact: Delta tracking doesn't work for first backup

3. test_backups.py:228-229 - Missing test coverage

# TODO add tests for iterating over backups (marker, dirname)
# TODO add tests for backups dir lockfile

Impact: Critical functionality untested

Proposed Actions

Each TODO should be:

Converted into a GitHub issue with proper description
Assigned a priority
Either implemented or explicitly documented as "won't fix" with reasoning

Impact

Medium - Represents technical debt that should be addressed or documented.

# Unaddressed TODO comments in codebase **Priority:** Medium **Component:** Multiple **Type:** Technical Debt ## Description There are several TODO comments in the code that represent unfinished features or decisions to be made. ## List of TODOs ### 1. cli.py:99 - "add cleaning up from non-finished backups" ```python # TODO add cleaning up from non-finished backups backup.cleanup_old_backups(backups_dir=backups_dir_abs, dry_run=args.dry_run) ``` **Impact:** Incomplete backups could accumulate, wasting space ### 2. backup.py:347 - "maybe should be run if first backup too?" ```python # TODO maybe should be run if first backup too? if latest_backup is not None: process_backed_entry(...) ``` **Impact:** Delta tracking doesn't work for first backup ### 3. test_backups.py:228-229 - Missing test coverage ```python # TODO add tests for iterating over backups (marker, dirname) # TODO add tests for backups dir lockfile ``` **Impact:** Critical functionality untested ## Proposed Actions Each TODO should be: 1. Converted into a GitHub issue with proper description 2. Assigned a priority 3. Either implemented or explicitly documented as "won't fix" with reasoning ## Impact **Medium** - Represents technical debt that should be addressed or documented.

Sign in to join this conversation.

No Label

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: snegov/cura-te-ipsum#28