From 3c8d247b282c05d8ea8141671a5dd959c8f7681b Mon Sep 17 00:00:00 2001 From: Maxim Shulga Date: Sun, 2 Aug 2026 18:16:43 -0700 Subject: [PATCH] Record why DISABLE_VERIFY_CERTIFICATE never worked The daemon reads the key with seafile_session_config_get_bool, which is a case sensitive g_strcmp0(value, "true"), so the capitalised True stored by released images up to 0.0.13 was read as false and verification stayed on for anyone who asked to disable it. The default was never affected, since any value other than "true" is false. Rendering booleans in lower case fixed this; this only writes down what the change actually repaired, for anyone who reported the flag as broken. --- IMPROVEMENTS.md | 8 ++++++-- README.md | 5 ++++- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/IMPROVEMENTS.md b/IMPROVEMENTS.md index 8a30dfd..8e0a974 100644 --- a/IMPROVEMENTS.md +++ b/IMPROVEMENTS.md @@ -95,8 +95,12 @@ Acceptance criteria: they were compared against, so `usermod` ran on every start. - [x] Reject negative and malformed numeric values with useful messages. - [x] Do not pass `None` as a Seafile configuration value. Booleans are also - rendered as `true`/`false` rather than Python's `True`/`False`, since the - daemon reads that setting with its boolean accessor. + rendered as `true`/`false` rather than Python's `True`/`False`. This fixed + `DISABLE_VERIFY_CERTIFICATE`, which never worked: the daemon reads the key + with `seafile_session_config_get_bool`, which is + `g_strcmp0(value, "true") == 0`, so the stored `True` was false and + verification stayed on for anyone who asked to disable it. The default was + never affected, because anything other than `true` is false. Acceptance criteria: diff --git a/README.md b/README.md index 69a9ace..98086e6 100644 --- a/README.md +++ b/README.md @@ -47,7 +47,10 @@ volumes: confirmation before being deleted simultaneously. Default value is _500_. - `DISABLE_VERIFY_CERTIFICATE` - set to _true_ to disable server's certificate verification. Default value is _false_. Booleans accept _true_/_false_, - _1_/_0_, _yes_/_no_ and _on_/_off_, in any case. + _1_/_0_, _yes_/_no_ and _on_/_off_, in any case. Note that this setting had no + effect in released images up to and including 0.0.13: the value reached the + Seafile daemon capitalised, which it does not recognise, so verification + stayed on even when the variable was set. The default was never affected. - `UPLOAD_LIMIT` / `DOWNLOAD_LIMIT` - upload/download speed limit in B/s (bytes per second). Default values are _0_ (unlimited).