Reject UID or GID zero unless a documented use case requires it (#32)
* Reject UID or GID zero unless a documented use case requires it setup_uid() would happily remap the seafile user to UID/GID 0, which after the previous non-root fix would mean drop_privileges() drops straight back into root. main() now rejects --uid/SEAFILE_UID and --gid/SEAFILE_GID being 0 with exit code 2, before setup_uid() runs. Verified against the real image via tests/smoke.sh. * Clarify the GID=0 rejection message Copilot review: 'group root' isn't a commonly used phrase. Name GID 0 as the root group explicitly instead. --------- Co-authored-by: Maxim Shulga <maxim.shulga@alludo.com>
This commit is contained in:
1 parent
6d32460b13
commit
6f8af2cfa4
3 files changed
+25
-1
No files matched your search
@@ -139,6 +139,22 @@ else
|
||||
fail "negative limit not reported: $(echo "$out" | tail -1)"
|
||||
fi
|
||||
|
||||
out=$(docker run --rm $PLATFORM_ARG -e SERVER_HOST=h -e USERNAME=u -e PASSWORD=p \
|
||||
-e LIBRARY_ID=x -e SEAFILE_UID=0 "$IMAGE" 2>&1; echo "rc=$?")
|
||||
if echo "$out" | grep -q "uid must not be 0" && [ "$(echo "$out" | tail -1)" = "rc=2" ]; then
|
||||
pass "SEAFILE_UID=0 is rejected"
|
||||
else
|
||||
fail "SEAFILE_UID=0 not rejected: $out"
|
||||
fi
|
||||
|
||||
out=$(docker run --rm $PLATFORM_ARG -e SERVER_HOST=h -e USERNAME=u -e PASSWORD=p \
|
||||
-e LIBRARY_ID=x -e SEAFILE_GID=0 "$IMAGE" 2>&1; echo "rc=$?")
|
||||
if echo "$out" | grep -q "gid must not be 0" && [ "$(echo "$out" | tail -1)" = "rc=2" ]; then
|
||||
pass "SEAFILE_GID=0 is rejected"
|
||||
else
|
||||
fail "SEAFILE_GID=0 not rejected: $out"
|
||||
fi
|
||||
|
||||
echo "== a mounted secret is read and stays out of the environment"
|
||||
printf 's3cret-from-file\n' > "$WORK/pw"
|
||||
out=$(docker run --rm $PLATFORM_ARG -v "$WORK/pw:/run/secrets/pw:ro" \
|
||||
|
||||
Reference in new issue
Block a user