Name the stored strings instead of implying booleans
The note explained a string comparison but wrote the values as if they were booleans, which is the exact confusion it exists to clear up. Both places now say which string was stored and which one the daemon accepts.
This commit is contained in:
1 parent
3c8d247b28
commit
ca4c906814
2 files changed
+11
-7
No files matched your search
+6
-4
@@ -96,11 +96,13 @@ Acceptance criteria:
|
||||
- [x] Reject negative and malformed numeric values with useful messages.
|
||||
- [x] Do not pass `None` as a Seafile configuration value. Booleans are also
|
||||
rendered as `true`/`false` rather than Python's `True`/`False`. This fixed
|
||||
`DISABLE_VERIFY_CERTIFICATE`, which never worked: the daemon reads the key
|
||||
`DISABLE_VERIFY_CERTIFICATE`, which never worked. The daemon reads the key
|
||||
with `seafile_session_config_get_bool`, which is
|
||||
`g_strcmp0(value, "true") == 0`, so the stored `True` was false and
|
||||
verification stayed on for anyone who asked to disable it. The default was
|
||||
never affected, because anything other than `true` is false.
|
||||
`g_strcmp0(value, "true") == 0`, so it accepts only the exact string
|
||||
`"true"`. Python's `str(True)` stored the string `"True"`, which did not
|
||||
match and was therefore read as false, leaving verification on for anyone
|
||||
who asked to disable it. The default stored the string `"False"`, which is
|
||||
also not `"true"` and so was correctly read as false.
|
||||
|
||||
Acceptance criteria:
|
||||
|
||||
|
||||
Reference in new issue
Block a user