Merge pull request #13 from snegov/feature/dockerignore-and-unused-imports
Trim the build context and drop unused imports
This commit is contained in:
4 files changed
+15
-4
No files matched your search
@@ -0,0 +1,9 @@
|
|||||||
|
# Only requirements.txt, dsc/ and start.py belong in the build context.
|
||||||
|
*
|
||||||
|
!requirements.txt
|
||||||
|
!start.py
|
||||||
|
!dsc/
|
||||||
|
|
||||||
|
# Keep local artifacts out even though dsc/ is re-included above.
|
||||||
|
dsc/**/__pycache__/
|
||||||
|
dsc/**/*.py[cod]
|
||||||
+6
-2
@@ -171,10 +171,14 @@ Acceptance criteria:
|
|||||||
|
|
||||||
- [ ] Separate configuration, subprocess execution, library resolution, and
|
- [ ] Separate configuration, subprocess execution, library resolution, and
|
||||||
status monitoring so each can be tested independently.
|
status monitoring so each can be tested independently.
|
||||||
- [ ] Remove unused imports and unnecessary dependencies.
|
- [x] Remove unused imports and unnecessary dependencies. Both pinned
|
||||||
|
requirements are used; `urllib3` is imported directly but only pinned
|
||||||
|
transitively through `requests`.
|
||||||
- [ ] Add type annotations and static checks at external-input boundaries.
|
- [ ] Add type annotations and static checks at external-input boundaries.
|
||||||
- [ ] Make logging configurable and avoid forced dependency debug logs.
|
- [ ] Make logging configurable and avoid forced dependency debug logs.
|
||||||
- [ ] Add `.dockerignore` and reduce unnecessary image packages.
|
- [ ] Add `.dockerignore` and reduce unnecessary image packages. `.dockerignore`
|
||||||
|
is in place; `binutils` and `squashfs-tools` are still shipped in the final
|
||||||
|
image because the AppImage is unpacked in the same stage.
|
||||||
|
|
||||||
### Establish a visible maintenance process
|
### Establish a visible maintenance process
|
||||||
|
|
||||||
|
|||||||
@@ -4,7 +4,6 @@ import os
|
|||||||
import subprocess
|
import subprocess
|
||||||
import time
|
import time
|
||||||
from typing import Optional
|
from typing import Optional
|
||||||
from urllib.parse import urlparse
|
|
||||||
|
|
||||||
from cached_property import cached_property_with_ttl
|
from cached_property import cached_property_with_ttl
|
||||||
import requests
|
import requests
|
||||||
|
|||||||
Reference in new issue
Block a user