* Handle temporary RPC failures and daemon restarts without corrupting state
watch_status()'s per-iteration RPC read had no error handling: an
unexpected failure (the daemon crashing or restarting mid-call, or any
other transient RPC hiccup) propagated straight out of the loop and
crashed the whole container, indistinguishable from a real fatal
error.
The read is now wrapped: an unexpected exception logs a warning and
retries on the next tick, leaving prev_status untouched so the next
successful read still reports every real change. A stop signal or
another DscError still ends the loop exactly as before - the wrapper
explicitly re-raises DscError first, since GracefulShutdown is one and
must not be swallowed by the broader except below it.
Verified against the real image: a container survives seaf-daemon
being killed outright, logging the failure instead of exiting.
* Log a traceback on RPC failure and strengthen the state test
Copilot review:
- The RPC failure warning logged only the message; add exc_info so a
repeated failure in production is actually debuggable.
- The 'prior state is not corrupted' test asserted the warning fired
but never proved a real change after the failure was still detected
and logged, which is the actual property being claimed.
---------
Co-authored-by: Maxim Shulga <maxim.shulga@alludo.com>
Maksim ShulgaandMaxim Shulga
123705aa53