Record why DISABLE_VERIFY_CERTIFICATE never worked

The daemon reads the key with seafile_session_config_get_bool, which is a
case sensitive g_strcmp0(value, "true"), so the capitalised True stored by
released images up to 0.0.13 was read as false and verification stayed on for
anyone who asked to disable it. The default was never affected, since any
value other than "true" is false.

Rendering booleans in lower case fixed this; this only writes down what the
change actually repaired, for anyone who reported the flag as broken.
This commit is contained in:
Maxim Shulga committed 2026-08-02 18:16:43 -07:00
1 parent 872585833b
commit 3c8d247b28
2 files changed
+10 -3

No files matched your search

+6 -2
View File
@@ -95,8 +95,12 @@ Acceptance criteria:
they were compared against, so `usermod` ran on every start. they were compared against, so `usermod` ran on every start.
- [x] Reject negative and malformed numeric values with useful messages. - [x] Reject negative and malformed numeric values with useful messages.
- [x] Do not pass `None` as a Seafile configuration value. Booleans are also - [x] Do not pass `None` as a Seafile configuration value. Booleans are also
rendered as `true`/`false` rather than Python's `True`/`False`, since the rendered as `true`/`false` rather than Python's `True`/`False`. This fixed
daemon reads that setting with its boolean accessor. `DISABLE_VERIFY_CERTIFICATE`, which never worked: the daemon reads the key
with `seafile_session_config_get_bool`, which is
`g_strcmp0(value, "true") == 0`, so the stored `True` was false and
verification stayed on for anyone who asked to disable it. The default was
never affected, because anything other than `true` is false.
Acceptance criteria: Acceptance criteria:
+4 -1
View File
@@ -47,7 +47,10 @@ volumes:
confirmation before being deleted simultaneously. Default value is _500_. confirmation before being deleted simultaneously. Default value is _500_.
- `DISABLE_VERIFY_CERTIFICATE` - set to _true_ to disable server's certificate - `DISABLE_VERIFY_CERTIFICATE` - set to _true_ to disable server's certificate
verification. Default value is _false_. Booleans accept _true_/_false_, verification. Default value is _false_. Booleans accept _true_/_false_,
_1_/_0_, _yes_/_no_ and _on_/_off_, in any case. _1_/_0_, _yes_/_no_ and _on_/_off_, in any case. Note that this setting had no
effect in released images up to and including 0.0.13: the value reached the
Seafile daemon capitalised, which it does not recognise, so verification
stayed on even when the variable was set. The default was never affected.
- `UPLOAD_LIMIT` / `DOWNLOAD_LIMIT` - upload/download speed limit in B/s - `UPLOAD_LIMIT` / `DOWNLOAD_LIMIT` - upload/download speed limit in B/s
(bytes per second). Default values are _0_ (unlimited). (bytes per second). Default values are _0_ (unlimited).