Maxim Shulga
b75863ba51
get_local_libraries unpacked "line.rsplit(maxsplit=3)" into three names, but maxsplit=3 yields up to four fields. seaf-cli prints "name id path" separated by whitespace, so any library whose name contains a space produced a fourth field and raised ValueError, which nothing caught. The failure only appeared after the first run: the list is empty until a library has been synced, so a container would work when it was set up and then crash on every restart. seaf-cli list --json returns name, id and path as structured fields, which display output cannot represent unambiguously for names or paths containing whitespace. Its exit code is now checked and unreadable output is reported as a daemon error instead of a traceback. The image smoke check asserts that the installed seaf-cli offers --json and --token, so a future version bump that drops either fails the build rather than the container.
77 lines
3.2 KiB
Docker
77 lines
3.2 KiB
Docker
FROM debian:bookworm-slim
|
|
|
|
# Seafile discontinued its APT repository; linux-clients.seafile.com no longer
|
|
# resolves to a reachable host. Upstream now ships the CLI as an AppImage.
|
|
ARG SEAFILE_CLI_VERSION=9.0.19
|
|
ARG SEAFILE_CLI_SHA256=4af848362d8493be218b903e17e3fbbd282e9ea94af000211ce05c3f44e48715
|
|
ARG SEAFILE_CLI_URL=https://sos-ch-dk-2.exo.io/seafile-downloads/Seafile-cli-x86_64-${SEAFILE_CLI_VERSION}.AppImage
|
|
|
|
RUN apt-get update && \
|
|
apt-get install -y --no-install-recommends \
|
|
ca-certificates curl binutils squashfs-tools python3.11-venv && \
|
|
rm -rf /var/lib/apt/lists/*
|
|
|
|
# An AppImage is an ELF runtime with a squashfs image appended. Unpack the
|
|
# squashfs directly rather than executing the AppImage: running it needs FUSE,
|
|
# and so a privileged container. Verify the download before unpacking it.
|
|
RUN curl -fsSL -o /tmp/seaf-cli.AppImage "$SEAFILE_CLI_URL" && \
|
|
echo "${SEAFILE_CLI_SHA256} /tmp/seaf-cli.AppImage" | sha256sum -c - && \
|
|
offset=$(LC_ALL=C readelf -h /tmp/seaf-cli.AppImage | awk '\
|
|
/Start of section headers/ {s=$5} \
|
|
/Size of section headers/ {z=$5} \
|
|
/Number of section headers/{n=$5} \
|
|
END {print s + z * n}') && \
|
|
unsquashfs -q -d /opt/seafile-cli -o "$offset" /tmp/seaf-cli.AppImage && \
|
|
rm /tmp/seaf-cli.AppImage
|
|
|
|
# The bundled AppRun expects APPDIR, which only the AppImage runtime sets.
|
|
# seaf-cli also requires seaf-daemon on PATH, so keep usr/bin ahead of it.
|
|
RUN printf '%s\n' \
|
|
'#!/bin/sh' \
|
|
'APPDIR=/opt/seafile-cli' \
|
|
'export PATH="$APPDIR/usr/bin${PATH:+:$PATH}"' \
|
|
'export LD_LIBRARY_PATH="$APPDIR/usr/lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}"' \
|
|
'export PYTHONPATH="$APPDIR/usr/lib/python3.9/site-packages${PYTHONPATH:+:$PYTHONPATH}"' \
|
|
'exec python3 "$APPDIR/usr/bin/seaf-cli" "$@"' \
|
|
> /usr/local/bin/seaf-cli && \
|
|
chmod +x /usr/local/bin/seaf-cli
|
|
|
|
# Use virtual environment
|
|
ENV VIRTUAL_ENV=/opt/venv
|
|
RUN python3 -m venv --system-site-packages $VIRTUAL_ENV
|
|
ENV PATH="$VIRTUAL_ENV/bin:$PATH"
|
|
|
|
# The APT package used to install the seafile/pysearpc RPC bindings system-wide.
|
|
# The AppImage keeps them in its own tree, so put them on the venv path: dsc
|
|
# imports seafile directly, not only through seaf-cli. They are pure Python, so
|
|
# the 3.9 build works unchanged on this interpreter.
|
|
RUN python3 -c "import pathlib, site; \
|
|
pathlib.Path(site.getsitepackages()[0], 'seafile-appimage.pth') \
|
|
.write_text('/opt/seafile-cli/usr/lib/python3.9/site-packages\n')"
|
|
|
|
# Install app requirements
|
|
WORKDIR /dsc
|
|
COPY requirements.txt ./
|
|
RUN pip install --no-cache-dir -r requirements.txt
|
|
|
|
# Copy app
|
|
COPY dsc ./dsc/
|
|
COPY start.py ./start.py
|
|
|
|
# Create seafile user and init seafile client
|
|
RUN chmod +x /dsc/start.py && \
|
|
useradd -U -d /dsc -s /bin/bash seafile && \
|
|
usermod -G users seafile && \
|
|
mkdir -p /dsc/seafile-data && \
|
|
chown seafile:seafile -R /dsc
|
|
|
|
# Smoke checks: seaf-cli has no --version flag, so assert its subcommands, and
|
|
# confirm the app's own imports resolve.
|
|
RUN seaf-cli --help | grep -q 'download-by-name' && \
|
|
seaf-cli sync --help | grep -q '\--token' && \
|
|
seaf-cli list --help | grep -q '\--json' && \
|
|
python3 -c "import seafile, pysearpc, dsc.client, dsc.misc"
|
|
|
|
VOLUME /dsc/seafile-data
|
|
CMD ["./start.py"]
|