Commands were joined into a string and passed to "su -c", so a login shell parsed every interpolated value. A library name is chosen on the server, and "sync -d /dsc/seafile/<name>" put it straight into that string: a library named 'Docs; touch /tmp/pwned; #' ran as an arbitrary command. Confirmed against the built image before and after this change. Every command is now an argument list executed by "runuser --", which execs directly with no shell. runuser -u sets the same HOME and a PATH that still finds the seaf-cli wrapper, so the daemon environment is unchanged. The password no longer needs its surrounding quotes, which also fixes passwords containing quotes, dollar signs, and backticks. Library names are untrusted, so dsc/paths.py reduces each one to a single path component and proves the result stays under the libraries directory with symlinks resolved. Empty, ".", "..", and names containing a separator are skipped with a warning; names that would collide are suffixed with their library ID rather than sharing a directory. Tests cover quotes, command substitutions, separators, newlines, absolute paths, parent traversal, Unicode, and colliding names. They run in a separate CI job so application failures stay distinguishable from packaging failures.
docker-seafile-client
Docker image for Seafile CLI client.
Image on Docker Hub: snegov/seafile-client.
Docker-compose example:
Also available as a ready-to-use compose.example.yaml.
services:
seafile-client:
restart: always
image: snegov/seafile-client:0.0.13
environment:
LIBRARY_ID: "79867cbf-2944-488d-9105-852463ecdf9e:my_library"
SERVER_HOST: seafile.example.com
USERNAME: user
PASSWORD: password
SEAFILE_UID: 1000
SEAFILE_GID: 100
hostname: dsc
volumes:
- /home/johndow/seafile:/dsc/seafile
- sync-data:/dsc/seafile-data
container_name: seafile-client
volumes:
sync-data:
Environment variables:
LIBRARY_ID- library to sync, ID or name. Multiple libraries could be separated by colon:.SERVER_HOST- hostname of your Seafile server, eg: seafile.example.com. If you're using non-standard port, you can specify it here, eg: seafile.example.com:8080.USERNAME/PASSWORD- credentials to access Seafile server.SEAFILE_UID/SEAFILE_GID- UID/GID of user inside container. You can use it to set permissions on synced files. Default values are 1000 / 1000.DELETE_CONFIRM_THRESHOLD- represents the number of files that require confirmation before being deleted simultaneously. Default value is 500.DISABLE_VERIFY_CERTIFICATE- set to true to disable server's certificate verification. Default value is false.UPLOAD_LIMIT/DOWNLOAD_LIMIT- upload/download speed limit in B/s (bytes per second). Default values are 0 (unlimited).
Volumes:
/dsc/seafile-dataSeafile client data directory (sync status, etc)./dsc/seafileSeafile libraries content.
Some notes
LIBRARY_ID could be library ID or library name. Library ID is a 36-character
string, which is a part of URI when you open library in webUI. Library name is
a name you gave to library when you created it.
Libraries will be synced in subdirectories of /dsc/seafile directory inside
container. You can mount it to host directory to access files.
The subdirectory is named after the library, with whitespace replaced by
underscores. A library is skipped with a warning when its name cannot be a
directory of its own: an empty name, ., .., or a name containing /. Two
libraries whose names would produce the same directory both get their library
ID appended, so they never share one. Everything is created under the
libraries directory (/dsc/seafile, or the deprecated /data when that
exists); a library name can never place it elsewhere.
hostname parameter is optional, but it's recommended to set it to some unique
value, it will be shown in Seafile webUI as client name (terminal-dsc in
given example).
sync-data volume is optional too, but it's recommended to use it. Otherwise,
sync status will be lost when container is recreated.
At the moment there is no suitable way to confirm deletion of large number of
files. So, if you're going to delete a lot of files, you should set
DELETE_CONFIRM_THRESHOLD to some larger value.